feat: add toBeOneOf() expectation #1290
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshafik
force-pushed
the
feature/toBeOneOf
branch
from
8319e3d
to
d87bd72
Compare
dshafik
force-pushed
the
feature/toBeOneOf
branch
from
d87bd72
to
ae40c0f
Compare
KorvinSzanto
reviewed
Oct 7, 2024
| public function toBeOneOf(Closure ...$tests): self | ||
| { | ||
| if ($tests === []) { | ||
| return $this; |
| } | ||
|
|
||
| if (count($matches) > 1) { | ||
| throw new ExpectationFailedException('Failed asserting value matches exactly one expectation (matches: '.implode(', ', $matches).').'); |
There was a problem hiding this comment.
Rather than outputting the keys, I'd just output a count of passes and fails for a few reasons:
- Keys are limited to ints, or variable names due to using the splat operator rather than accepting an iterable, for example:
->toBeOneOf(thisIsTheOnlyWayToNameAnExpectation: fn($e) => ..., spaces_are_not_allowed: fn($e) => ...) - If you were accepting an iterable rather than using a splat, array keys aren't guaranteed to be unique
- There could be a ton of expectations passed to this function, causing a failure to output a huge error
- Just counting passes and failures reduces the memory overhead
You can also output the total count of assertions ran by checking the delta of Assert::getCount() before and after.
|
|
||
| use PHPUnit\Framework\ExpectationFailedException; | ||
|
|
||
| expect(true)->toBeTrue()->and(false)->toBeFalse(); |
There was a problem hiding this comment.
Suggested change
| expect(true)->toBeTrue()->and(false)->toBeFalse(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Description:
Adds a
toBeOneOfexpectation that allows you to ensure that a value matches only one of a set of assertions. This is complimentary to #1286.